rpk: explicitly add Arg validation to plugins #18723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In redpanda-data#18650 we added Arg validations for every comman and an automatic "walk" through the command space to add cobra.NoArgs. Plugins were not taken into account, this commit explicitly set the cobra.MinimumArg(0) to avoid adding "NoArgs" on execution.
twmb
approved these changes
May 30, 2024
|
new failures in https://buildkite.com/redpanda/redpanda/builds/49694#018fca7f-c04a-4fb3-be31-3c3d06f4a741: |
|
https://buildkite.com/redpanda/redpanda/builds/49694#018fca7f-c04a-4fb3-be31-3c3d06f4a741/6-9337 Reported new unrelated error in #18724 |
|
/backport v24.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18650 we added Arg validations for every
command and an automatic "walk" through the command space to add cobra.NoArgs.
Plugins were not taken into account, this commit
explicitly set the cobra.MinimumArg(0) to avoid
adding "NoArgs" on execution.
Backports Required
Release Notes